Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-splitter: nested panels should have min-width: 0 to leverage flex-basis correctly #13323

Closed
acekeeper93 opened this issue Jul 12, 2023 · 0 comments · Fixed by #13324
Closed
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@acekeeper93
Copy link
Contributor

Describe the bug

If the content inside nested panels exceeds flex-basis value it won't leverage flex-basis correctly.
For example if I put some very wide p-table and set it scrollable it won't show the scrollbar and just cut the table.

Environment

Windows 11

Reproducer

No response

Angular version

14.2.12

PrimeNG version

14.2.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.3.0

Browser(s)

Chrome Version 114.0.5735.199 (Official Build) (64-bit)

Steps to reproduce the behavior

<p-splitter *ngIf="showLeftPanel; else noLeftPanel" [style]="{ 'height': '100%' }" [panelSizes]="[20, 80]"> <ng-template pTemplate> <div>Left Column </div> </ng-template> <ng-template pTemplate> <p-table> with many columns, scrollable </ng-template> </p-splitter>

Expected behavior

No response

@acekeeper93 acekeeper93 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 12, 2023
acekeeper93 added a commit to acekeeper93/primeng that referenced this issue Jul 12, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 26, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 26, 2023
mertsincan pushed a commit that referenced this issue Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants