Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Table & Scroller #14205

Closed
wS2Zth opened this issue Nov 25, 2023 · 1 comment · Fixed by #14206
Closed

Component: Table & Scroller #14205

wS2Zth opened this issue Nov 25, 2023 · 1 comment · Fixed by #14206
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@wS2Zth
Copy link
Contributor

wS2Zth commented Nov 25, 2023

Describe the bug

EN:
When using Lazy Load with Virtual Scroll in the table component, the onLazyLoad function always works twice (the lazyLoadOnInit flag has no effect).

(If I remember correctly, this problem has been going on since the Virtual Scroll implementation was changed, not specifically related to the PrimeNG 17 release.)

TR:
Table component'inde Virtual Scroll ile Lazy Load kullanıldığında, onLazyLoad fonksiyonu iki kez çalışıyor (lazyLoadOnInit'in bu duruma bir etkisi yok).

(Yanlış hatırlamıyorsam, bu sorun Virtual Scroll implementasyonu değiştirildiğinden beri devam ediyor, özellikle PrimeNG 17 versiyonu ilgili değil.)

Environment

Angular : 17
PrimeNG : 17
Arc Browser
macOS Sonomo 14.1.1

Reproducer

https://stackblitz.com/edit/github-a4wbfw

Angular version

17.0.3

PrimeNG version

17.0.0-beta.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v18.18.2

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@wS2Zth wS2Zth added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 25, 2023
wS2Zth added a commit to wS2Zth/primeng that referenced this issue Nov 25, 2023
@wS2Zth
primefaces#14205 - Fixed onLazyLoad function running twice.
4acdf75
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 22, 2024
cetincakiroglu added a commit that referenced this issue Mar 22, 2024
@cetincakiroglu
Merge pull request #14206 from wS2Zth/#14205
f576adb 
#14205 - Fixed onLazyLoad function running twice.
@cetincakiroglu
Copy link
Contributor

Fixed in #14206

@cetincakiroglu cetincakiroglu mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

#14205 - Fixed onLazyLoad function running twice. wS2Zth/primeng
2 participants
@wS2Zth @cetincakiroglu