Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordian : TextArea shortcuts are not working when used in Accordian Panels #14368

Closed
siddhareddy opened this issue Dec 14, 2023 · 2 comments · Fixed by #14392 or #14455
Closed

Accordian : TextArea shortcuts are not working when used in Accordian Panels #14368

siddhareddy opened this issue Dec 14, 2023 · 2 comments · Fixed by #14392 or #14455
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@siddhareddy
Copy link
Contributor

Describe the bug

When Text Area components are used in a accordion panels and focus is within the text area content, the traditional keyboard shortcuts such for using Shift+Home , Shift+End for highlighting the text and Home, End to move within the text area are not working and moves to next accordion instead.
image
When focus is within the text area, text-area shortcuts should take precedence
These shortcuts work fine when the text area is outside of accordian

Environment

Node : 20

Reproducer

https://stackblitz.com/edit/mwq3yh?file=src%2Fapp%2Fdemo%2Faccordion-basic-demo.html

Angular version

17.0.0

PrimeNG version

17.1.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

Chrome 120

Steps to reproduce the behavior

  1. Goto demo-bug
  2. move the cursor to within anywhere inside text area
  3. try shortcut such as shift+end to highlight text till the end of line

Expected behavior

  1. Text Area shortcuts should work when the cursor is inside the textarea and behave similar to the functionality of inputtextarea-demo
@siddhareddy siddhareddy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 14, 2023
@mehmetcetin01140 mehmetcetin01140 added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 19, 2023
@mehmetcetin01140 mehmetcetin01140 self-assigned this Dec 19, 2023
mehmetcetin01140 added a commit that referenced this issue Dec 19, 2023
@cetincakiroglu cetincakiroglu added this to the 17.2.0 milestone Dec 20, 2023
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 20, 2023
cetincakiroglu added a commit that referenced this issue Dec 20, 2023
Fixed #14368 - Accordion | TextArea shortcuts are not working when us…
@siddhareddy
Copy link
Contributor Author

Hello @cetincakiroglu and @mehmetcetin01140

While Shift+Home and Shift+End shortcuts are now functional, other essential text area shortcuts (e.g., Home, End, Ctrl+Home, Ctrl+End, Up/Down arrows) remain inoperable when the cursor is within a text area nested within an accordion. This behavior is likely due to conflict with accordion-specific shortcuts.

Notably, the PrimeVue library demonstrates correct functionality for the same component combination primevue-working-demo

Could we have the same behavior in primeng too ?
primeng-updated-demo-17.2.0

Shortcut Description Working Status in 17.2.0
Up Arrow Previous line
Down Arrow Next line
Ctrl+Home Beginning of the text
Ctrl+End End of the text
Home Beginning of the line
End End of the line
Ctrl+Right Arrow End of the next word
Ctrl+Left Arrow Beginning of the previous word
Shift+Home Select text to beginning of current line
Shift+End Select text to end of current line
Left Arrow Previous character
Right Arrow Next character

@siddhareddy
Copy link
Contributor Author

@mehmetcetin01140 and @cetincakiroglu
Sorry to be behind the issue, but did you get a chance to take a look at this issue and the above demo ?
Its not only affecting the text area but also inputtext field as well when trying to use keyboard shortcuts in an accordian
Appreciate if you suggest any workaround or reconsider the issue

@cetincakiroglu cetincakiroglu modified the milestones: 17.2.0, 17.Future Dec 28, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 28, 2023
bhishman-desai added a commit to bhishman-desai/primeng that referenced this issue Dec 30, 2023
bhishman-desai added a commit to bhishman-desai/primeng that referenced this issue Jan 5, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.Future, 17.3.2 Jan 8, 2024
cetincakiroglu added a commit that referenced this issue Jan 10, 2024
Fixed #14368 - Accordian : TextArea shortcuts are not working when us…
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
3 participants