Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-dropdown: selecting an option or clearing the value should clear the filter input #14503

Closed
mlz11 opened this issue Jan 8, 2024 · 1 comment · Fixed by #14511
Closed

p-dropdown: selecting an option or clearing the value should clear the filter input #14503

mlz11 opened this issue Jan 8, 2024 · 1 comment · Fixed by #14511
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@mlz11
Copy link

mlz11 commented Jan 8, 2024

Describe the bug

Please see Steps to reproduce the behavior and screen recording below.

9062fbea-abbf-4e1c-932b-0628c72e292a.mp4

Environment

Please see Steps to reproduce the behavior below.

Reproducer

No response

Angular version

16.2.12

PrimeNG version

16.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Type desired value in the dropdown's filter field.
  2. Select an option based on the ones provided post-filtering.
  3. Unwrap dropdown.
  4. Observe that the previously typed value in the filter field has not been cleared.
  5. Clear the dropdown value by clicking on the clear icon.
  6. Observe that the previously typed value in the filter field has not been cleared.

Expected behavior

The value previously typed in the filter field should be cleared.

@mlz11 mlz11 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2024
akshayaqburst pushed a commit to qburst/primeng_qb_2 that referenced this issue Jan 8, 2024
@cetincakiroglu cetincakiroglu added this to the 17.3.2 milestone Jan 10, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 10, 2024
cetincakiroglu added a commit that referenced this issue Jan 10, 2024
fix: #14503, p-dropdown: selecting an option or clearing the value should clear the filter input
mlz11 added a commit to mlz11/primeng that referenced this issue Jan 10, 2024
@mlz11
Copy link
Author

mlz11 commented Jan 10, 2024

Thank you @akshayaqburst for your PR 🙏🏻

Hi @cetincakiroglu 👋🏻 Thanks for managing the issue. I opened #14528 in order to reset the dropdown's filter not only upon clearing, but also when selecting an option.
Would it be ok for you ?

Thanks !

mlz11 added a commit to mlz11/primeng that referenced this issue Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
2 participants