p-dropdown: optionValue is not working when object has property 'group'

[kiknadze]

Describe the bug

I performed a version migration from PrimeNG 14 to 16.9.1, and immediately the dropdowns that receive an object but have their value and label specified stopped working. The options are not displayed in the HTML.

As I investigated problem is 'group' property of object. If group is undefined it works properly, but if group has any value then it shows empty list.

<p-dropdown
      [options]="templates"
      inputId="templateId"
      placeholder="Select Template"
      optionLabel="name"
      optionValue="id"
      formControlName="templateId">
</p-dropdown>

Environment

"@angular/animations": "^16.2.12",
"@angular/cdk": "^16.2.12",
"@angular/common": "^16.2.12",
"@angular/compiler": "^16.2.12",
"@angular/core": "^16.2.12",
"@angular/forms": "^16.2.12",
"@angular/platform-browser": "^16.2.12",
"@angular/platform-browser-dynamic": "^16.2.12",
"@angular/router": "^16.2.12",
"@angular/service-worker": "^16.2.12",
"ngx-bootstrap": "^11.0.2",
"bootstrap": "^5.2.0",
"font-awesome": "^4.7.0",
"@fortawesome/angular-fontawesome": "^0.13.0",
"@fortawesome/fontawesome-svg-core": "^1.2.36",
"@fortawesome/free-regular-svg-icons": "^5.15.1",
"@fortawesome/free-solid-svg-icons": "^5.15.4",
"primeicons": "^5.0.0",
"primeng": "^16.9.1",
"rxjs": "~6.6.3",
"zone.js": "^0.13.3"

Reproducer

No response

Angular version

16.2

PrimeNG version

16.9.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response

[mertsincan]

Thanks a lot for your report! Could you please attach a stackblitz link for us to replicate? I added a milestone. If you attach a link, we'll fix it before the milestone is released.

[kiknadze]

stackblitz

https://stackblitz.com/edit/lfryhg?file=src%2Fapp%2Fdemo%2Fdropdown-basic-demo.ts

[tsinevik]

Hi, this is because dropdown has incorrect logic for choosing a template for option. It renders group template if option object has group property.
I have a PR opened (#14382) with fix for this issue for quite some time already. Would really appreciate if you push a fix for it as quick as possible.

[cetincakiroglu]

fixed in #14382