Issue 14304 - Improve check for selecting option template in Dropdown #14382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SoyDiego
approved these changes
Dec 18, 2023
|
@cetincakiroglu hi, I would really appreciate if you could check out this PR and provide some feedback if there's something wrong with it. We can't update to the Angular 17 for over a month because of that issue and we really don't won't to refactor part of the app only for dropdown to remain the same behavior on a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #14304
Use
isOptionGroupmethod when selecting template to render option. Otherwise options may be rendered empty if they havegroupproperty, but Dropdown component has[group]="false". It is the same logic as in MultiSelect and Autocomplete components.