Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When p-chart is put into a p-fieldset, the chart is not responsive anymre #14739

Closed
blackat opened this issue Feb 6, 2024 · 1 comment · Fixed by #14817
Closed

When p-chart is put into a p-fieldset, the chart is not responsive anymre #14739

blackat opened this issue Feb 6, 2024 · 1 comment · Fixed by #14817
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@blackat
Copy link

blackat commented Feb 6, 2024

Describe the bug

Hello,
When I put a chart into a fieldset, the chart is not responsive anymore.
If I enlarge the window the graph resize, but when I shrink the window the chart and the fieldset does not resize.

I have just done a try like this

<div style="margin: 1rem">
  <p-fieldset legend="Chart" [toggleable]="true">
     <div class="card">
        <p-chart type="line" [data]="data" [options]="options" [responsive]="true"
             [height]="'400hv'"></p-chart>
     </div>
  </p-fieldset>
</div>

Environment

I am using Mac OSX, PrimeNG 17.5.0 and Charts 4.4.1 with Angular 17.1.1.

Reproducer

No response

Angular version

17.1.1

PrimeNG version

17.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.3.0

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

I would expect that if I put the chart into the fieldset I can resize the window and the chart resize as well.

@blackat blackat added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 6, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.7.0, 17.8.0 Feb 12, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Feb 15, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 15, 2024
mehmetcetin01140 added a commit that referenced this issue Feb 15, 2024
cetincakiroglu added a commit that referenced this issue Feb 22, 2024
Fixed #14739 - Fieldset | When p-chart is put into a p-fieldset, the …
@blackat
Copy link
Author

blackat commented Feb 25, 2024

Just updated, it works nicely, thanks a lot @cetincakiroglu 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants