Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree: Node drop points are not contained in a <ul> or <ol> #14911

Closed
WTW-Steve-Martin opened this issue Feb 29, 2024 · 0 comments · Fixed by #14918
Closed

Tree: Node drop points are not contained in a <ul> or <ol> #14911

WTW-Steve-Martin opened this issue Feb 29, 2024 · 0 comments · Fixed by #14918
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User
Milestone
17.10.0

Comments

@WTW-Steve-Martin
Copy link

WTW-Steve-Martin commented Feb 29, 2024 •
edited
Loading

Describe the bug

The Axe Dev Tools for Accessibility is reporting the following issue:
image

It seems to be unhappy that the droppoint <li> is not directly inside a <ul> or <ol> tag.

Please could we update this control so that the Axe scan passes?

Environment

Windows 10

Reproducer

No response

Angular version

17.2.1

PrimeNG version

17.7.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Install the Axe Dev Tools for Accessibility plug-in.
  2. Visit the PrimeNG dropdown page (https://primeng.org/tree) on Chrome/Edge browser.
  3. Scan the page with Axe

Expected behavior

The Axe scan doesn't return this error.
@WTW-Steve-Martin WTW-Steve-Martin added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 29, 2024
@cetincakiroglu cetincakiroglu added this to the 17.10.0 milestone Mar 1, 2024
@cetincakiroglu cetincakiroglu self-assigned this Mar 1, 2024
@cetincakiroglu cetincakiroglu added PRO Support Issue was reported by PRO User and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 1, 2024
@cetincakiroglu cetincakiroglu added the Component: Accessibility Issue or pull request is related to WCAG or ARIA label Mar 1, 2024
mehmetcetin01140 added a commit that referenced this issue Mar 1, 2024
@mehmetcetin01140
Fixed #14911 - Tree | Node drop points are not contained in a <ul> or…
64440f0 
… <ol>
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Mar 1, 2024
Merged
cetincakiroglu added a commit that referenced this issue Mar 5, 2024
@cetincakiroglu
Merge pull request #14918 from primefaces/issue-14911
aeba1e2 
Fixed #14911 - Tree | Node drop points are not contained in a <ul> or…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User
Projects
None yet
Milestone
17.10.0
Development

Successfully merging a pull request may close this issue.

Fixed #14911 - Tree | Node drop points are not contained in a <ul> or… primefaces/primeng
3 participants
@cetincakiroglu @mehmetcetin01140 @WTW-Steve-Martin