Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons: Wrong value for PrimeIcons.SORT_ALPHA_ALT_DOWN and others #14965

Closed
dorthrithil opened this issue Mar 7, 2024 · 1 comment · Fixed by #14966
Closed

Icons: Wrong value for PrimeIcons.SORT_ALPHA_ALT_DOWN and others #14965

dorthrithil opened this issue Mar 7, 2024 · 1 comment · Fixed by #14966
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.10.0

Comments

@dorthrithil
Copy link
Contributor

Describe the bug

PrimeIcons.SORT_ALPHA_ALT_DOWN is set to pi pi-sort-alpha-alt-down but the correct classname is pi-sort-alpha-down-alt.

Environment

primeicons: 6.0.1
primeng: 17.6.0

Reproducer

https://stackblitz.com/edit/github-dqmnwd?file=src%2Fapp%2Fapp.component.html

Angular version

17.1.3

PrimeNG version

17.6.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@dorthrithil dorthrithil added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 7, 2024
@dorthrithil dorthrithil mentioned this issue Mar 7, 2024
Merged
@dorthrithil
Copy link
Contributor Author

I noticed some more broken definitions and created a PR for it: #14966

@dorthrithil dorthrithil changed the title Icons: Wrong value for PrimeIcons.SORT_ALPHA_ALT_DOWN Icons: Wrong value for PrimeIcons.SORT_ALPHA_ALT_DOWN and others Mar 7, 2024
@cetincakiroglu cetincakiroglu added this to the 17.10.0 milestone Mar 7, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 7, 2024
cetincakiroglu added a commit that referenced this issue Mar 7, 2024
@cetincakiroglu
Merge pull request #14966 from dorthrithil/master
01ebdad 
Fix #14965: Fix broken -alt icon definitions in PrimeIcons class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.10.0
Development

Successfully merging a pull request may close this issue.

Fix #14965: Fix broken -alt icon definitions in PrimeIcons class dorthrithil/primeng-fix-sort-icon
2 participants
@dorthrithil @cetincakiroglu