Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeTable | wrong value comparison #15178

Closed
cetincakiroglu opened this issue Mar 27, 2024 · 0 comments · Fixed by #15179
Closed

TreeTable | wrong value comparison #15178

cetincakiroglu opened this issue Mar 27, 2024 · 0 comments · Fixed by #15179
Assignees
Labels
LTS-FIXED-15.4.18 LTS-FIXED-16.9.8 LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@cetincakiroglu
Copy link
Contributor

node1 === node2 is always false. It should use ObjectUtils.equals() to compare.

    equals(node1: TreeTableNode, node2: TreeTableNode) {
        return this.compareSelectionBy === 'equals' ? node1 === node2 : ObjectUtils.equals(node1.data, node2.data, this.dataKey);
    }
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE labels Mar 27, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 27, 2024
@cetincakiroglu cetincakiroglu self-assigned this Mar 27, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 27, 2024
cetincakiroglu added a commit that referenced this issue Mar 27, 2024
Fixed #15178 - Use ObjectUtils for comparison
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-15.4.18 LTS-FIXED-16.9.8 LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants