Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: colorPicker - color not updated in selection square with reactive forms #15266

Closed
ppieczul opened this issue Apr 12, 2024 · 0 comments · Fixed by #15319
Closed

Component: colorPicker - color not updated in selection square with reactive forms #15266

ppieczul opened this issue Apr 12, 2024 · 0 comments · Fixed by #15319
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.15.0

Comments

@ppieczul
Copy link

Describe the bug

colorPicker which uses forms, not ngModel, does not update the selected color square in realtime, when mouse is moving over the color pallette.
However, when an empty onChange handler is added to it (onChange)="true", it starts updating correctly.

Environment

Angular + electron on Chrome and MacOS

Reproducer

https://stackblitz.com/edit/github-4fz6wx?file=README.md

Angular version

17.0.8

PrimeNG version

17.11.0, reproduces on 17.13.0 too

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

21.7.3

Browser(s)

Chrome

Steps to reproduce the behavior

run stackblitz example, the instruction is in html

Expected behavior

The colorPicker should update its selected color in realtime always, without the empty onChange handler added.
@ppieczul ppieczul added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 12, 2024
@ppieczul ppieczul changed the title Component: colorPicker - color not updated in Component: colorPicker - color not updated in selection square with reactive forms Apr 12, 2024
volvachev added a commit to volvachev/primeng that referenced this issue Apr 19, 2024
@volvachev
fix(primeng/p-colorPicker): reactive control not updated when mousemo…
d3e6ae4 
…ve triggered

Fixes primefaces#15266.
@volvachev volvachev mentioned this issue Apr 19, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 26, 2024
@cetincakiroglu cetincakiroglu added this to the 17.15.0 milestone Apr 26, 2024
nbrown-ScottLogic pushed a commit to nbrown-ScottLogic/primeng that referenced this issue May 1, 2024
@volvachev @nbrown-ScottLogic
fix(primeng/p-colorPicker): reactive control not updated when mousemo…
cabf09f 
…ve triggered

Fixes primefaces#15266.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.15.0
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-colorPicker): reactive control not updated when mousemove triggered volvachev/primeng
2 participants
@ppieczul @cetincakiroglu