Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Button: Aria Label not correctly working #15342

Closed
tomhuber96 opened this issue Apr 23, 2024 · 0 comments · Fixed by #15385
Closed

Split Button: Aria Label not correctly working #15342

tomhuber96 opened this issue Apr 23, 2024 · 0 comments · Fixed by #15385
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.16.0

Comments

@tomhuber96
Copy link

Describe the bug

The ButtonProps and MenuButtonProps are not correctly defined and cannot be used currently.

They define a property 'ariaLabel', but in the code in is accessed as 'aria-label'.
The same problem exists for the other properties of MenuButtonProps.

For reference see:

I tested it in v17.13, but as you see in the links above, it should still exist in 17.14.1.

Environment

I am using angular 17

Reproducer

No response

Angular version

17

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

10

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@tomhuber96 tomhuber96 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 23, 2024
@maruthumj maruthumj mentioned this issue Apr 27, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.16.0 milestone May 3, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 3, 2024
cetincakiroglu added a commit that referenced this issue May 3, 2024
@cetincakiroglu
Merge pull request #15385 from maruthumj/pbutton-arialabel
efb963d 
Bug #15342 - Split Button: Aria Label not correctly working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.16.0
Development

Successfully merging a pull request may close this issue.

Bug #15342 - Split Button: Aria Label not correctly working maruthumj/primeng
2 participants
@tomhuber96 @cetincakiroglu