Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabMenu doesn't scroll to active item when it's set programatically #15973

Closed
soundigy opened this issue Jul 8, 2024 · 0 comments · Fixed by #15982 · 4 remaining pull requests
Closed

TabMenu doesn't scroll to active item when it's set programatically #15973

soundigy opened this issue Jul 8, 2024 · 0 comments · Fixed by #15982 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.6

Comments

@soundigy
Copy link

soundigy commented Jul 8, 2024

Describe the bug

When TabMenu's activeItem is set from the code and there are more items then can be displayed on the screen (scrolling is needed and enabled), and the activeItem is not currently visible on the screen, then scrolling doesn't occur.

Environment

Tested on both PrimeNG v16.9.12-lts and 17.18.3 and the behaviour is the same.

Reproducer

https://stackblitz.com/edit/pvzkh6?file=src%2Fapp%2Fdemo%2Ftab-menu-scrollable-demo.ts

Angular version

16.2.0

PrimeNG version

16.9.12-lts

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@soundigy soundigy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 8, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 8, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jul 8, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.4 milestone Jul 8, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jul 8, 2024
Merged
@mehmetcetin01140 mehmetcetin01140 modified the milestones: 17.18.4, 17.18.5, 17.18.6 Jul 11, 2024
cetincakiroglu added a commit that referenced this issue Jul 25, 2024
@cetincakiroglu
Merge pull request #15982 from primefaces/issue-15973
0d7c90c 
Fixed #15973 - TabMenu doesn't scroll to active item when it's set pr…
This was referenced Aug 16, 2024
Open
Open
This was referenced Aug 30, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Sep 20, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.6
Development

Successfully merging a pull request may close this issue.

Fixed #15973 - TabMenu doesn't scroll to active item when it's set pr… primefaces/primeng
[Snyk] Upgrade primeng from 17.14.1 to 17.18.6 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.7 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.8 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.9 Rodolphe33/gestion-personnel
[Snyk] Upgrade: , , , , , , , , , tslib, , primeng, zone.js Rodolphe33/gestion-personnel
[Snyk] Upgrade: , , , , , , , , , tslib, , primeng, zone.js Rodolphe33/gestion-personnel
[Snyk] Upgrade: , , , , , , , , , tslib, , primeng, zone.js Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.10 Rodolphe33/gestion-personnel
2 participants
@soundigy @mehmetcetin01140