Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-tree: Unselectable children is selected when selecting parent #16430

Closed
LouLeGrain opened this issue Sep 25, 2024 · 0 comments · Fixed by #16431
Closed

p-tree: Unselectable children is selected when selecting parent #16430

LouLeGrain opened this issue Sep 25, 2024 · 0 comments · Fixed by #16431
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.11

Comments

@LouLeGrain
Copy link
Contributor

Describe the bug

If a node with a disabled children is selected and propagateSelectionDown is true by default, then the unselectable children are selected, without possibility to unselect them.

Enregistrement.de.l.ecran.2024-09-25.a.11.48.00.mov

Environment

Angular ^17.3.6 / PrimeNG ^17.18.0

Reproducer

https://stackblitz.com/edit/github-fos6jj?file=src%2Fapp%2Fapp.component.ts

Angular version

^17.3.6

PrimeNG version

^17.18.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

  1. Create a p-tree component with a node that has an unselectable children
  2. select parent node
  3. unselectable children node is selected

Expected behavior

Unselectable treenode should be unselectable, even when selecting parent node
@LouLeGrain LouLeGrain added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 25, 2024
LouLeGrain added a commit to LouLeGrain/primeng that referenced this issue Sep 25, 2024
@LouLeGrain
fix primefaces#16430
bcf299a
@LouLeGrain LouLeGrain mentioned this issue Sep 25, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 26, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.11 milestone Sep 26, 2024
cetincakiroglu added a commit that referenced this issue Sep 26, 2024
@cetincakiroglu
Merge pull request #16431 from LouLeGrain/fix-#16430
ec9eea3 
Fix #16430 - p-tree: Unselectable children is selected when selecting parent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.11
Development

Successfully merging a pull request may close this issue.

Fix #16430 - p-tree: Unselectable children is selected when selecting parent LouLeGrain/primeng
2 participants
@LouLeGrain @cetincakiroglu