Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match @angular libs to allow angular12 upgrade to rxjs v7.x #10802

Closed
wants to merge 1 commit into from

Conversation

jasonkenneth
Copy link

Even though Angular 12 shipped with rxjs v6, they made changes to support v7.

angular/angular#41897
angular/angular#42991
https://github.com/angular/angular/blob/12.2.12/packages/core/package.json#L14

When running npm install in an Angular 12 project with rxjs v7x, we get the following error.

npm ERR! Found: [email protected]
npm ERR! node_modules/rxjs
npm ERR!   rxjs@"7.4.0" from the root project
npm ERR!   peer rxjs@"^6.5.3 || ^7.0.0" from @angular/[email protected]
npm ERR!   node_modules/@angular/common
npm ERR!     @angular/common@"12.2.12" from the root project
npm ERR!     peer @angular/common@"^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0" from [email protected]
npm ERR!     node_modules/primeng
npm ERR!       primeng@"12.2.1" from the root project
npm ERR!     2 more (@angular/forms, @angular/platform-browser)
npm ERR!   2 more (@angular/core, @angular/forms)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rxjs@"^6.0.0" from [email protected]
npm ERR! node_modules/primeng
npm ERR!   primeng@"12.2.1" from the root project

@jasonkenneth
Copy link
Author

Created issue #10804.

@yigitfindikli
Copy link
Contributor

Hi @jasonkenneth,

Thanks for your report and effort. Added manually.

Best Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants