Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: #11561 - Image Preview Toolbar fix #11562

Merged

Conversation

vinnyab28
Copy link
Contributor

###Defect Fixes
Issue: #11561

Updated the z-index for p-image-toolbar to make Image Preview Toolbar visible over the images

@cetincakiroglu cetincakiroglu self-requested a review June 6, 2022 14:34
@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 6, 2022
@cetincakiroglu cetincakiroglu reopened this Jun 7, 2022
@cetincakiroglu cetincakiroglu merged commit a297969 into primefaces:master Jun 7, 2022
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 7, 2022
@cetincakiroglu
Copy link
Contributor

Hi @vinnyab28 ,

Thanks for your effort and contribution, good catch!
I need to revert and close this pr because by design we don't set z-index directly from the component's css, we have helper functions to do it. This fix will be implemented by our dev team.

Thanks again for your support

@cetincakiroglu cetincakiroglu removed their request for review June 7, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants