Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 12883: autocomplete not scrolling on arrow down #12885

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix issue 12883: autocomplete not scrolling on arrow down #12885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7398368
fix issue 12883: autocomplete not scrolling
Apr 12, 2023
189d6cb
module imported 2x
Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/app/components/autocomplete/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,6 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr
console.warn('The itemSize property is deprecated, use virtualScrollItemSize property instead.');
}

overlay: HTMLDivElement;

itemsWrapper: HTMLDivElement;

itemTemplate: TemplateRef<any>;
Expand Down Expand Up @@ -482,7 +480,7 @@ export class AutoComplete implements AfterViewChecked, AfterContentInit, OnDestr
if (this.highlightOptionChanged) {
this.zone.runOutsideAngular(() => {
setTimeout(() => {
if (this.overlay && this.itemsWrapper) {
if (this.overlayViewChild && this.itemsWrapper) {
let listItem = DomHandler.findSingle(this.overlayViewChild.overlayViewChild.nativeElement, 'li.p-highlight');

if (listItem) {
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/fileupload/fileupload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CommonModule, CommonModule, DOCUMENT, isPlatformBrowser } from '@angular/common';
import { CommonModule, DOCUMENT, isPlatformBrowser } from '@angular/common';
import { HttpClient, HttpClientModule, HttpEvent, HttpEventType, HttpHeaders } from '@angular/common/http';
import {
AfterContentInit,
Expand Down