Menu no close on item click #13386
Menu no close on item click #13386
Conversation
…or controlling whether the menu should be closed when a menu item is clicked The closeOnClick input property is added to the Menu component to allow developers to control whether the menu should be closed when a menu item is clicked. By default, closeOnClick is set to true, meaning the menu will be closed when a menu item is clicked. This provides more flexibility and customization options for the behavior of the menu component.
… add preventDefault and stopPropagation when closeOnClick is false 🐛 fix(menu.ts): add preventDefault and stopPropagation when closeOnClick is false to prevent default behavior of menuitem click event The duplicate closeOnClick input declaration has been removed to improve code readability and maintainability. When closeOnClick is false and the menu is a popup, the preventDefault and stopPropagation methods are called to prevent the default behavior of the menuitem click event, ensuring that the menu does not close when a menuitem is clicked.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
cetincakiroglu
added
the
Status: Discussion
|
LGTM! |
|
Hi @jhcpeixoto , Thank you for taking the time to submit your pull request. We genuinely appreciate your effort and interest in improving our project. After careful review and consideration, we have decided not to merge your pull request at this time. Please understand that this decision does not reflect negatively on the quality of your work. We value every contribution and understand the effort you've put into it. However, upon review, we believe that the changes proposed in this pull request may not align with the current goals or direction of the project. Our team is continuously evaluating and prioritizing features and enhancements based on various factors, including project roadmap, user feedback, and technical considerations. We encourage you to continue contributing to the project and to stay engaged with our community. Your input and contributions are valuable, and we look forward to seeing more of your work in the future. Once again, thank you for your contribution, and please don't hesitate to reach out if you have any questions or would like further feedback. Best regards, |
cetincakiroglu
removed
the
Status: Discussion
|
In other words, this can probably be solved with passthrough props. |
Defect Fixes
🔧 chore(menu.ts): Add closeOnClick input property to Menu component for controlling whether the menu should be closed when a menu item is clicked.
Description
The closeOnClick input property is added to the Menu component to allow developers to control whether the menu should be closed when a menu item is clicked. By default, closeOnClick is set to true, meaning the menu will be closed when a menu item is clicked. This provides more flexibility and customization options for the behavior of the menu component.
Changes Made