-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #13390 #13608
Merged
Merged
Fix for issue #13390 #13608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
rosenthalj
changed the title
changed inline: 'start' to inline: 'nearest'
fixes for issue #13390
Sep 3, 2023
Note: changes fixed formatting errors that were prexisting before my changes
…pload (removing spaces from {}
Add in your first comment the text |
Hi @rosenthalj Thanks a lot for the contribution, we appreciate your effort and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13390
Listed below are 6 movies:
The first 3 movies show the original functionality before any changes
The second 3 movies show the new functionality after the changes
Note: The navigation after the fix is different than before the fixe. I personally think its better
1_beforeChangesOriginalProblem.mov
2_beforeChangesWithRightAndLeftMouseButtonLargerWidth.mov
3_beforeChangesWithRightAndLeftMouseButtonSmallerWidth.mov
4_afterChangesOriginalProblem.mov
5_afterChangesWithRightAndLeftMouseButtonLargerWidth.mov
6_afterChangesWithRightAndLeftMouseButtonSmallerWidth.mov