Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Add virtual scroll on Tree Select Component #13771

Merged
merged 9 commits into from
Mar 22, 2024

Conversation

GaetanRouzies
Copy link
Contributor

@GaetanRouzies GaetanRouzies commented Sep 28, 2023

Feature Requests

Add virtual scroll on Tree Select Component so we can use the Tree Select with large datasets.

Fixed #13772

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 9:14am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2023 9:14am

@GaetanRouzies
Copy link
Contributor Author

@SoyDiego Thanks for your feedback, I implemented your code in [my last commit].(0f8e514)

}

.p-treeselect-virtual-scroll .p-tree-container.p-scroller-content {
padding: 1.25rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong this styles themes should be in primeng-sass-theme project: https://github.com/primefaces/primeng-sass-theme/
Maybe @cetincakiroglu can confirm you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can i have a confirmation ?

@GaetanRouzies
Copy link
Contributor Author

GaetanRouzies commented Dec 13, 2023

Still waiting for confirmation, it's been 3 months

Remove unnecessary css
Copy link

vercel bot commented Mar 22, 2024

@cetincakiroglu is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@cetincakiroglu cetincakiroglu merged commit c943671 into primefaces:master Mar 22, 2024
0 of 3 checks passed
@cetincakiroglu
Copy link
Contributor

Hi @GaetanRouzies,

Huge thanks for the effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: TreeSelect with Virtual Scroll
3 participants