Fixed inputNumber with numeric prefix is not working as expected #15398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he check in backspace and delete to always be true
|
@nbrown-ScottLogic is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
cetincakiroglu
added
the
Status: Pending Review
|
If I enter the number same as suffix in empty input, it doubles the number. Could you please also take a look at it? Also, there are accordion related code in your PR, could you please remove them. It should be one file updated: inputnumber.
|
cetincakiroglu
added
the
Resolution: Needs Revision
…f it is then just add the input not the prefix/suffix
nbrown-ScottLogic
force-pushed
the
prefixCharacterPrevented
branch
from
c048575
to
f780621
Compare
|
@cetincakiroglu Changes you've requested should be present now, thanks for the feedback. |
|
Hi, Thanks a lot for the effort and support! |
cetincakiroglu
removed
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED #15311
The issue was essentially that each time a value was entered a RegExp would be used to replace the prefix and suffix with '' however the RegExp had the /g flag and as such would replace all occurances of the pre/suffix including any occurances entered by the user. I also fixed some issues around the use of backspace and delete keys when the selector was around the prefix and suffix