Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tieredmenu): remove aria level attribute from list item #15474

Merged

Conversation

ppc-harmoney
Copy link
Contributor

@ppc-harmoney ppc-harmoney commented May 7, 2024

Resolves #15130

This is my first contribution. Forgive me if I have failed to follow S.O.P.

Defect Fixes

This PR removes the aria-level attribute from the <li> items in the tiered menu component. The reason being that this attribute was flagged as incorrect by axe devtools (presumably due to the role attribute being incompatible with aria-level?)

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 9:52am

@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for the effort and support!

@cetincakiroglu cetincakiroglu merged commit 1319d8d into primefaces:master May 8, 2024
2 checks passed
@ppc-harmoney
Copy link
Contributor Author

You're very welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SplitButton: menu item is using 'aria-level' attribute incorrectly
2 participants