Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #16020 Table: column-filter outside click does not close when it is inside a dialog component #16021

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

ymg2006
Copy link
Contributor

@ymg2006 ymg2006 commented Jul 13, 2024

#16020
Table: column-filter outside click does not close when it is inside a dialog component

Table: column-filter outside click does not close when it is inside a dialog component
Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2024 7:00am

Copy link
Contributor

@cetincakiroglu cetincakiroglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@cetincakiroglu cetincakiroglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Jul 18, 2024
@ymg2006
Copy link
Contributor Author

ymg2006 commented Jul 21, 2024

@cetincakiroglu the issue is fixed with a search in dialogs where they have date-picker class.
the reason is the commit #15094. So, this will only find date picker dialog elements not all of them which causes all the dialogs not close when there is another dialog open in whole document.
the latest commit fixes the issue without breaking commit #15094.

@cetincakiroglu
Copy link
Contributor

Hi @ymg2006

Thanks a lot for the effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants