Fix #16308: Flawed example in table paginator documentation #16309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new line correctly identifies the last page by checking if the index after the current page's last item reaches or exceeds the total length of the customers list. The old line incorrectly identifies the last page, only working correctly when the amount of items in the table is an exact multiple of the rows per page count.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Wendelstein7
changed the title
SoyDiego
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16308 - The example code for programmatically paginating trough tables, in the
isLastPage()function, is flawed because it only works correctly when the amount of items in the table is an exact multiple of the rows per page count.The new line correctly identifies the last page by checking if the index after the current page's last item reaches or exceeds the total length of the customers list.
The old line incorrectly identifies the last page, only working correctly when the amount of items in the table is an exact multiple of the rows per page count.