Skip to content

Commit

Permalink
Refactor #1484 - Improve Password implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
mertsincan committed Aug 11, 2020
1 parent f1c232c commit 79ffccb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 21 deletions.
20 changes: 5 additions & 15 deletions src/components/password/Password.css
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
.p-password-panel {
padding: .25em .5em;
margin-top: 2px;
}

.p-password-panel .p-password-meter {
height: 10px;
.p-password-meter {
background:transparent url("./images/password-meter.png") no-repeat left top;
padding: 0;
margin: 0;
}

.p-password-info {
margin-top: .25em;
height: 10px;
}

.p-password-panel-overlay {
position: absolute;
}
display: none;
}
12 changes: 6 additions & 6 deletions src/components/password/Password.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ export class Password extends Component {
this.panel.style.zIndex = String(DomHandler.generateZIndex());
this.panel.style.display = 'block';
setTimeout(() => {
DomHandler.addClass(this.panel, 'p-input-overlay-visible');
DomHandler.removeClass(this.panel, 'p-input-overlay-hidden');
DomHandler.addClass(this.panel, 'p-connected-overlay-visible');
DomHandler.removeClass(this.panel, 'p-connected-overlay-hidden');
}, 1);
DomHandler.absolutePosition(this.panel, this.inputEl);
}
Expand All @@ -58,12 +58,12 @@ export class Password extends Component {

onBlur(e) {
if (this.props.feedback) {
DomHandler.addClass(this.panel, 'p-input-overlay-hidden');
DomHandler.removeClass(this.panel, 'p-input-overlay-visible');
DomHandler.addClass(this.panel, 'p-connected-overlay-hidden');
DomHandler.removeClass(this.panel, 'p-connected-overlay-visible');

setTimeout(() => {
this.panel.style.display = 'none';
DomHandler.removeClass(this.panel, 'p-input-overlay-hidden');
DomHandler.removeClass(this.panel, 'p-connected-overlay-hidden');
}, 150);
}

Expand Down Expand Up @@ -140,7 +140,7 @@ export class Password extends Component {

createPanel() {
this.panel = document.createElement('div');
this.panel.className = 'p-password-panel p-component p-highlight p-hidden p-password-panel-overlay p-input-overlay';
this.panel.className = 'p-password-panel p-component p-password-panel-overlay p-connected-overlay';
this.meter = document.createElement('div');
this.meter.className = 'p-password-meter';
this.info = document.createElement('div');
Expand Down

0 comments on commit 79ffccb

Please sign in to comment.