Fixed #2238 - [Bug]: ReadOnly InputNumber is editable

primefaces · Nov 7, 2021 · 94cb5fb · 94cb5fb
1 parent 464f82a
commit 94cb5fb
Showing 1 changed file with 27 additions and 10 deletions.
diff --git a/src/components/inputnumber/InputNumber.js b/src/components/inputnumber/InputNumber.js
@@ -296,39 +296,39 @@ export class InputNumber extends Component {
     }
 
     onUpButtonMouseDown(event) {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.inputRef.current.focus();
             this.repeat(event, null, 1);
             event.preventDefault();
         }
     }
 
     onUpButtonMouseUp() {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.clearTimer();
         }
     }
 
     onUpButtonMouseLeave() {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.clearTimer();
         }
     }
 
     onUpButtonKeyUp() {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.clearTimer();
         }
     }
 
     onUpButtonKeyDown(event) {
-        if (event.keyCode === 32 || event.keyCode === 13) {
+        if (!this.props.disabled && !this.props.readOnly && (event.keyCode === 32 || event.keyCode === 13)) {
             this.repeat(event, null, 1);
         }
     }
 
     onDownButtonMouseDown(event) {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.inputRef.current.focus();
             this.repeat(event, null, -1);
 
@@ -337,37 +337,45 @@ export class InputNumber extends Component {
     }
 
     onDownButtonMouseUp() {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.clearTimer();
         }
     }
 
     onDownButtonMouseLeave() {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.clearTimer();
         }
     }
 
     onDownButtonKeyUp() {
-        if (!this.props.disabled) {
+        if (!this.props.disabled && !this.props.readOnly) {
             this.clearTimer();
         }
     }
 
     onDownButtonKeyDown(event) {
-        if (event.keyCode === 32 || event.keyCode === 13) {
+        if (!this.props.disabled && !this.props.readOnly && (event.keyCode === 32 || event.keyCode === 13)) {
             this.repeat(event, null, -1);
         }
     }
 
     onInput(event) {
+        if (this.props.disabled || this.props.readOnly) {
+            return;
+        }
+
         if (this.isSpecialChar) {
             event.target.value = this.lastValue;
         }
         this.isSpecialChar = false;
     }
 
     onInputKeyDown(event) {
+        if (this.props.disabled || this.props.readOnly) {
+            return;
+        }
+
         this.lastValue = event.target.value;
         if (event.shiftKey || event.altKey) {
             this.isSpecialChar = true;
@@ -521,6 +529,10 @@ export class InputNumber extends Component {
     }
 
     onInputKeyPress(event) {
+        if (this.props.disabled || this.props.readOnly) {
+            return;
+        }
+
         let code = event.which || event.keyCode;
         let char = String.fromCharCode(code);
         const isDecimalSign = this.isDecimalSign(char);
@@ -535,6 +547,11 @@ export class InputNumber extends Component {
 
     onPaste(event) {
         event.preventDefault();
+
+        if (this.props.disabled || this.props.readOnly) {
+            return;
+        }
+
         let data = (event.clipboardData || window['clipboardData']).getData('Text');
         if (data) {
             let filteredData = this.parseValue(data);