Fix #3378: Data attributes not on hidden inputs (#3379)

primefaces · Sep 28, 2022 · c3e0734 · c3e0734
1 parent 5fc5825
commit c3e0734
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 13 deletions.
diff --git a/components/lib/autocomplete/AutoComplete.js b/components/lib/autocomplete/AutoComplete.js
@@ -512,7 +512,6 @@ export const AutoComplete = React.memo(
                     onClick={props.onClick}
                     onDoubleClick={props.onDblClick}
                     {...ariaProps}
-                    {...dataProps}
                 />
             );
         };
@@ -563,7 +562,6 @@ export const AutoComplete = React.memo(
                         onFocus={onMultiInputFocus}
                         onBlur={onMultiInputBlur}
                         {...ariaProps}
-                        {...dataProps}
                     />
                 </li>
             );
@@ -609,7 +607,6 @@ export const AutoComplete = React.memo(
         const listId = idState + '_list';
         const hasTooltip = ObjectUtils.isNotEmpty(props.tooltip);
         const otherProps = ObjectUtils.findDiffKeys(props, AutoComplete.defaultProps);
-        const dataProps = ObjectUtils.reduceKeys(otherProps, DomHandler.DATA_PROPS);
         const ariaProps = ObjectUtils.reduceKeys(otherProps, DomHandler.ARIA_PROPS);
         const className = classNames(
             'p-autocomplete p-component p-inputwrapper',

diff --git a/components/lib/checkbox/Checkbox.js b/components/lib/checkbox/Checkbox.js
@@ -75,7 +75,6 @@ export const Checkbox = React.memo(
         const checked = isChecked();
         const hasTooltip = ObjectUtils.isNotEmpty(props.tooltip);
         const otherProps = ObjectUtils.findDiffKeys(props, Checkbox.defaultProps);
-        const dataProps = ObjectUtils.reduceKeys(otherProps, DomHandler.DATA_PROPS);
         const ariaProps = ObjectUtils.reduceKeys(otherProps, DomHandler.ARIA_PROPS);
         const className = classNames(
             'p-checkbox p-component',
@@ -111,7 +110,6 @@ export const Checkbox = React.memo(
                             readOnly={props.readOnly}
                             required={props.required}
                             {...ariaProps}
-                            {...dataProps}
                         />
                     </div>
                     <div className={boxClass}>{icon}</div>

diff --git a/components/lib/dropdown/Dropdown.js b/components/lib/dropdown/Dropdown.js
@@ -640,7 +640,7 @@ export const Dropdown = React.memo(
 
             return (
                 <div className="p-hidden-accessible p-dropdown-hidden-select">
-                    <select ref={inputRef} required={props.required} defaultValue={option.value} name={props.name} tabIndex={-1} aria-hidden="true" {...dataProps}>
+                    <select ref={inputRef} required={props.required} defaultValue={option.value} name={props.name} tabIndex={-1} aria-hidden="true">
                         <option value={option.value}>{option.label}</option>
                     </select>
                 </div>
@@ -728,7 +728,6 @@ export const Dropdown = React.memo(
 
         const hasTooltip = ObjectUtils.isNotEmpty(props.tooltip);
         const otherProps = ObjectUtils.findDiffKeys(props, Dropdown.defaultProps);
-        const dataProps = ObjectUtils.reduceKeys(otherProps, DomHandler.DATA_PROPS);
         const ariaProps = ObjectUtils.reduceKeys(otherProps, DomHandler.ARIA_PROPS);
         const className = classNames(
             'p-dropdown p-component p-inputwrapper',

diff --git a/components/lib/inputswitch/InputSwitch.js b/components/lib/inputswitch/InputSwitch.js
@@ -60,7 +60,6 @@ export const InputSwitch = React.memo(
 
         const hasTooltip = ObjectUtils.isNotEmpty(props.tooltip);
         const otherProps = ObjectUtils.findDiffKeys(props, InputSwitch.defaultProps);
-        const dataProps = ObjectUtils.reduceKeys(otherProps, DomHandler.DATA_PROPS);
         const ariaProps = ObjectUtils.reduceKeys(otherProps, DomHandler.ARIA_PROPS);
         const className = classNames(
             'p-inputswitch p-component',
@@ -90,7 +89,6 @@ export const InputSwitch = React.memo(
                             tabIndex={props.tabIndex}
                             aria-checked={checked}
                             {...ariaProps}
-                            {...dataProps}
                         />
                     </div>
                     <span className="p-inputswitch-slider"></span>

diff --git a/components/lib/multiselect/MultiSelect.js b/components/lib/multiselect/MultiSelect.js
@@ -567,7 +567,6 @@ export const MultiSelect = React.memo(
 
         const hasTooltip = ObjectUtils.isNotEmpty(props.tooltip);
         const otherProps = ObjectUtils.findDiffKeys(props, MultiSelect.defaultProps);
-        const dataProps = ObjectUtils.reduceKeys(otherProps, DomHandler.DATA_PROPS);
         const ariaProps = ObjectUtils.reduceKeys(otherProps, DomHandler.ARIA_PROPS);
         const className = classNames(
             'p-multiselect p-component p-inputwrapper',
@@ -602,7 +601,6 @@ export const MultiSelect = React.memo(
                             disabled={props.disabled}
                             tabIndex={props.tabIndex}
                             {...ariaProps}
-                            {...dataProps}
                         />
                     </div>
                     {label}

diff --git a/components/lib/radiobutton/RadioButton.js b/components/lib/radiobutton/RadioButton.js
@@ -77,7 +77,6 @@ export const RadioButton = React.memo(
 
         const hasTooltip = ObjectUtils.isNotEmpty(props.tooltip);
         const otherProps = ObjectUtils.findDiffKeys(props, RadioButton.defaultProps);
-        const dataProps = ObjectUtils.reduceKeys(otherProps, DomHandler.DATA_PROPS);
         const ariaProps = ObjectUtils.reduceKeys(otherProps, DomHandler.ARIA_PROPS);
         const className = classNames(
             'p-radiobutton p-component',
@@ -111,7 +110,6 @@ export const RadioButton = React.memo(
                             required={props.required}
                             tabIndex={props.tabIndex}
                             {...ariaProps}
-                            {...dataProps}
                         />
                     </div>
                     <div className={boxClassName}>