Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeTable/DataTable goes to edit mode when selected (single click) #1292

Closed
m-vignesh opened this issue Apr 2, 2020 · 1 comment
Closed
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@m-vignesh
Copy link

I have set the editor ( a text field ) to a column. When I select the node, it to edit mode (on single click). There is no way to select a row without going to the edit mode. Edit mode should be enabled only on double click.

I'm submitting a ...

bug report

Have a look at Similar issue

Current behavior
Expander column of the node goes to edit mode on selection (single click)

Expected behavior
Expander column of the node should not go to edit mode on selection and should go to edit mode only on double click.

Environment:

  • React version:
    16.9

  • PrimeReact version:
    4.0

  • Browser: [all]

Screenshot from 2020-04-02 10-18-55

@mertsincan mertsincan added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 2, 2020
@mertsincan mertsincan added this to the 6.1.0 milestone Feb 10, 2021
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 8, 2021
@mertsincan mertsincan self-assigned this Mar 8, 2021
@mertsincan mertsincan changed the title TreeTable goes to edit mode when selected (single click) TreeTable/DataTable goes to edit mode when selected (single click) Mar 8, 2021
mertsincan added a commit that referenced this issue Mar 9, 2021
mertsincan added a commit that referenced this issue Mar 9, 2021
@mertsincan
Copy link
Member

Hi,

Added selectOnEdit property to DataTable and TreeTable.
selectOnEdit?: boolean = true -> Determines whether the cell editor will be opened when clicking to select any row on Selection and Cell Edit modes.

You can use selectOnEdit={false} property for this issue.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants