Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor's header cannot be hidden no matter what #1567

Closed
hstevanoski opened this issue Sep 10, 2020 · 3 comments · Fixed by #2453
Closed

Editor's header cannot be hidden no matter what #1567

hstevanoski opened this issue Sep 10, 2020 · 3 comments · Fixed by #2453
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@hstevanoski
Copy link

hstevanoski commented Sep 10, 2020

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request

Codesandbox Case
https://codesandbox.io/s/primereact-test-forked-uj3iq

Current behavior
You can't hide the Editor's header no matter what you do, even when you have custom toolbars enabled.
What's worse, is that the default header style messes up when this is the case.
The only way to hide the header is through CSS.

Expected behavior
The Editor's header should be either rendered conditionally when modules.toolbar is available or there should be an option to disable it.

  • React version:
    16.13.1

  • PrimeReact version:
    5.0.0

@hstevanoski
Copy link
Author

hstevanoski commented Dec 25, 2020

Maybe it's a good idea to deprecate the Editor component altogether in favor of the react-quill library?
I was having other problems, like not having the ability to set the Editor component being disabled runtime (with the Editor component, that option can only be set upon instantiation).
The react-quill library, on the other hand is much more flexible and provides much more functionality. In enterprise apps, that's exactly what we need, since we constantly face complex problems.
Don't get me wrong, this is purely well intended, but instead of maintaining this component, you could provide stylings for the Quill editor, so that they match the rest of the components and make it adhere to primereact's design.

@hstevanoski
Copy link
Author

Update on this:

Maybe it's a good idea to deprecate the Editor component altogether in favor of the react-quill library?

Judging by the number of issues and their dates since last publish, it looks like both quill and react-quill are abandoned.
I'm not sure if depending on react-quill is a good idea in the long term.

@mcandu mcandu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Aug 17, 2021
melloware added a commit to melloware/primereact that referenced this issue Nov 20, 2021
@melloware
Copy link
Member

PR Submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants