Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber: min/max fraction digits issues #1768

Closed
damonjmurray opened this issue Jan 22, 2021 · 3 comments
Closed

InputNumber: min/max fraction digits issues #1768

damonjmurray opened this issue Jan 22, 2021 · 3 comments
Assignees
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Milestone

Comments

@damonjmurray
Copy link

damonjmurray commented Jan 22, 2021

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/primereact-test-forked-jttso?file=/src/index.js

Current behavior

The codesandbox demonstrates three specific anomalous behaviours:

  1. minFractionDigits={0} is not respected and prevents the ability to enter fractional digits even when maxFractionDigits is specified
  2. If suffix, minFractionDigits, and maxFractionDigits are all specified, the content of the component is wiped when the minFractionDigits have been filled.
  3. Setting format={false} completely eliminates the ability to specify fractional digits even when minFractionDigits and maxFractionDigits have been specified.

Expected behavior

Respective to the above listed current behaviours:

  1. Specifying minFractionDigits={0} should still allow for fractional digits to be entered up to the specified maxFractionDigits
  2. Rather than wipe the content, fractional digits should continue to be entered up to the maxFractionDigits limit
  3. Setting format={false} should not influence the ability to enter fractional values.

Minimal reproduction of the problem with instructions

Provided in code sandbox: https://codesandbox.io/s/primereact-test-forked-jttso?file=/src/index.js

Please tell us about your environment:

  • React version: 17.0.1

  • PrimeReact version: 6.0.0

  • Browser: [Chrome XX | Firefox XX ]

  • Language: [ES6/7 | ES5]
@atipezda
Copy link

Any news on this ?

@melloware melloware changed the title Erroneous behaviour of InputNumber component InputNumber: min/max fraction digits issues Apr 29, 2022
@melloware
Copy link
Member

Here is my forked sandbox running your scenarios in PR 8.0.0 and they all appear fixed?

See: https://codesandbox.io/s/primereact-test-forked-fd0ukd?file=/src/index.js

Can you verify @atipezda @damonjmurray

@melloware melloware added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 29, 2022
@melloware melloware modified the milestones: 8.1.0, 8.0.0.Final Apr 29, 2022
@melloware
Copy link
Member

Closing for now will re-open if OP responds its not fixed in 8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Projects
None yet
Development

No branches or pull requests

4 participants