Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number formatting #53

Closed
dun-zilla opened this issue Jan 29, 2021 · 2 comments
Closed

Number formatting #53

dun-zilla opened this issue Jan 29, 2021 · 2 comments
Assignees
Milestone

Comments

@dun-zilla
Copy link

My locale is english.
The decimal symbol for datatype "currency" is not correct in editors (should be "."):

20210129_1404 - Screenshot - TestApplication_-_Google_Chrome_150

The navigation table's renderer does use the correct decimal symbol:

20210129_1404 - Screenshot - TestApplication_-_Google_Chrome_149

The thousands separator is not displayed neither in the editor nor by the table's renderer.

@rjahn
Copy link
Member

rjahn commented Feb 1, 2021

The format is set in the cellEditor definition.

@rjahn rjahn added this to the 0.9 milestone Feb 1, 2021
@maximilianweidenauer
Copy link
Contributor

Aside from the problem with the thousand seperator, PrimeReact currently has a bug with their fractional inputs e.g. you have a value 100,5, then you delete the ",5" part, you can't write a comma or dot again... primefaces/primereact#1768
They added the linked ticket to the milestone 6.1.0 so we will have to wait until then for this part of the problem.

@maximilianweidenauer maximilianweidenauer changed the title Currency formatting Number formatting Feb 11, 2021
maximilianweidenauer added a commit that referenced this issue Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants