Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When calendar is closed by clicking cancel button, It should be focus out #2638

Closed
walt1992 opened this issue Feb 11, 2022 · 0 comments · Fixed by #2639
Closed

Bug: When calendar is closed by clicking cancel button, It should be focus out #2638

walt1992 opened this issue Feb 11, 2022 · 0 comments · Fixed by #2639
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@walt1992
Copy link
Contributor

walt1992 commented Feb 11, 2022

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see

https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)

https://codesandbox.io/s/primereact-test-forked-v4c84?file=/src/index.js

Current behavior

when the calendar is open and closed by clicking clear button on footer, It is still stay focused.
So when a user click calendar input again, calandar not open if calendar input does not lose focus.
This leads bad user experience.

Expected behavior

Calendar input should be lose focus when calendar panel is closed by clicking clear button on footer.

Minimal reproduction of the problem with instructions

  1. render calendar with showButtonBar props is true
  2. open calendar panel
  3. close the panel by clicking cancel button positioned left clear
  4. click calendar input again
  5. check whether the calendar panel open or not

Please tell us about your environment:

mac os 12.1, vscode

  • React version:
    16.6

  • PrimeReact version:
    7.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

all

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 14, 2022
@yigitfindikli yigitfindikli modified the milestone: 7.2.1 Feb 14, 2022
@yigitfindikli yigitfindikli added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Feb 17, 2022
@yigitfindikli yigitfindikli added this to the 7.2.1 milestone Feb 17, 2022
yigitfindikli added a commit that referenced this issue Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants