-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox/RadioButton: stops working in labels #3054
Comments
As a fastfix you can add an onClick handler to label like this:
|
Confirmed and thanks for your report. PR submitted. |
@melloware may be event.stopPropagation is better? or it doesn't work? |
@melloware can you make a minor version plz too |
|
yes, you are right, thks for fast fix |
RadioButton has the same issue so I am fixing that too. |
@melloware @mertsincan still not working at 8.3.0 |
@AuthorProxy I just updated your code sandbox to 8.3.0 and its working for me? |
Yes - everything works, probably something was cached when I tested it. |
Describe the bug
Checkbox stops working when used inside
<label></label>
Looks like it handle check event twice, and no visual effect. But if you remove label or press on label (not directly checkbox) everything worked, not worked versions: my 8.1.1, codepen: 8.2.0Reproducer
https://codesandbox.io/s/primereact-test-forked-d6mnbc
PrimeReact version
8.1.1
React version
17.x
Language
ALL
Build / Runtime
Create React App (CRA)
Browser(s)
Chrome
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: