Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeSelect: props.panelFooterTemplate doesn't work #3088

Closed
ruben-ilciuc opened this issue Jul 21, 2022 · 1 comment · Fixed by #3089
Closed

TreeSelect: props.panelFooterTemplate doesn't work #3088

ruben-ilciuc opened this issue Jul 21, 2022 · 1 comment · Fixed by #3089
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.4.0

Comments

@ruben-ilciuc
Copy link

Describe the bug

I looked through the TreeSelect component and find out that the panelFooterTemplate is never used. SEE.
Instead, the corect property used is footer. SEE

Reproducer

https://codesandbox.io/s/primereact-test-forked-bmb3vj

PrimeReact version

8.1.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Import TreeSelect component
  2. Add property panelFooterTemplate with some value
  3. Open the Panel by clicking the TreeSelect
  4. See error: At the bottom of the Panel there is no footer

Expected behavior

The value from panelFooterTemplate is shown at the bottom of the panel.
@ruben-ilciuc ruben-ilciuc added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Jul 21, 2022
melloware added a commit to melloware/primereact that referenced this issue Jul 21, 2022
@melloware
Fix primefaces#3088: TreeSelect use panelFooterTemplate
16e6889
@melloware melloware added 👍 confirmed and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 21, 2022
@melloware melloware self-assigned this Jul 21, 2022
@melloware melloware added this to the 9.0.0 milestone Jul 21, 2022
@melloware melloware mentioned this issue Jul 21, 2022
Merged
@melloware
Copy link
Member

Good catch! Fixing....

melloware added a commit that referenced this issue Jul 21, 2022
@melloware
Fix #3088: TreeSelect use panelFooterTemplate (#3089)
604c8fb
@mertsincan mertsincan modified the milestones: 9.0.0, 8.4.0 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.4.0
Development

Successfully merging a pull request may close this issue.

Fix #3088: TreeSelect use panelFooterTemplate melloware/primereact
3 participants
@melloware @mertsincan @ruben-ilciuc