Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message: Override Icon using icon attribute #3196

Closed
nicholas-brooks opened this issue Aug 27, 2022 · 1 comment · Fixed by #3224
Closed

Message: Override Icon using icon attribute #3196

nicholas-brooks opened this issue Aug 27, 2022 · 1 comment · Fixed by #3224
Assignees
@melloware
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
8.5.0

Comments

@nicholas-brooks
Copy link

Describe the feature you would like to see added

Similar to other components (e.g. Button), it would be great to be able to override the icon for a Message component using the icon attribute.

e.g.

<Message
    severity="warn"
    icon=`fa-solid fa-circle-radiation`
    text="Current radiation levels are too high!" />

Is your feature request related to a problem?

No response

Describe the solution you'd like

New icon attribute on <Message /> component.

e.g.

<Message
    severity="warn"
    icon=`fa-solid fa-circle-radiation`
    text="Current radiation levels are too high!" />

Describe alternatives you have considered

No response

Additional context

No response
@nicholas-brooks nicholas-brooks added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Aug 27, 2022
@melloware
Copy link
Member

I like this idea.

habubey added a commit that referenced this issue Aug 31, 2022
@habubey
#3196 icon attribute added on message comp.
7d3f8cc
habubey added a commit that referenced this issue Aug 31, 2022
@habubey
#3196 icon attribute added on message comp. ts
8c30a1a
habubey added a commit that referenced this issue Aug 31, 2022
@habubey
#3196: Fixed svg icon issue and adjusted docs
08a3fcd
habubey added a commit that referenced this issue Aug 31, 2022
@habubey
#3196: ESLint rules fixed
e97170b
habubey added a commit that referenced this issue Sep 1, 2022
@habubey
#3196: ESLint added image alt prop
f81ac8a
melloware added a commit to melloware/primereact that referenced this issue Sep 1, 2022
@melloware
Fix primefaces#3196: Message(s) add icon attribute
58dd4c0
@melloware melloware mentioned this issue Sep 1, 2022
Merged
@melloware melloware self-assigned this Sep 1, 2022
@melloware melloware added Core Team Issue or pull request has been *opened* by a member of Core Team and removed Status: Discussion Issue or pull request needs to be discussed by Core Team labels Sep 1, 2022
@melloware melloware added this to the 8.5.0 milestone Sep 1, 2022
melloware added a commit that referenced this issue Sep 1, 2022
@melloware
Fix #3196: Message(s) add icon attribute (#3224)
3d336ec
@mertsincan mertsincan removed the Core Team Issue or pull request has been *opened* by a member of Core Team label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
8.5.0
Development

Successfully merging a pull request may close this issue.

Fix #3196: Message(s) add icon attribute melloware/primereact
3 participants
@nicholas-brooks @melloware @mertsincan