DataTable: Aria-label issues

[kyybo]

Describe the feature you would like to see added

Some elements (buttons or form elements) generated by the DataTable component do not have an 'aria-label' attribute.
Here is the list of the ones I spotted:

(1) The filter button generated by property filterDisplay='menu
(2) The paginator dropdown menu to select the number of rows to display. This element generates a 'p-hidden-accessible' div with an input element (with role="textbox") in it, but this input has no aria-label attribute. It also generates a 'p-dropdown-trigger' div with the role 'button' and this div has no aria-label attribute
(3) The radio buttons and checkboxes generated in selection mode

(1)

(2)

(3.1)


(3.2)

Is your feature request related to a problem?

No response

Describe the solution you'd like

An 'aria-label' attribute should be added to these elements. We can also consider being able to modify them if we want.

Describe alternatives you have considered

No response

Additional context

No response

[melloware]

Not sure what to make the accessibility text for the radio and checkbox?

[kyybo]

Not sure what to make the accessibility text for the radio and checkbox?

In my opinion, accessible names for the radio and checkbox must describe the element we selected thank to it.
In this case, I have no idea other than 'row-1', 'row-2', etc. by default. Or 'row-1-selector', 'row-2-selector', ...

[kyybo]

Another solution for the radio and checkbox accessibilty text : rather than using numbers we can specify a column of the table.

With this table :

we will have an attribute like : labelledby-field="name" and the checkboxes aria-label will be "James Butt row", "Josephine Darakjy row", etc

[melloware]

Yep I think I need to add a selectionAriaLabel so you can do selectionAriaLabel="name" and then the label would be "Select John Smith" or "Select Harry Williams". or "Unselect Harry Williams" if checked.