Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: bad rendering for button with icon and children #3382

Closed
kalinkrustev opened this issue Sep 29, 2022 · 0 comments · Fixed by #3383
Closed

Button: bad rendering for button with icon and children #3382

kalinkrustev opened this issue Sep 29, 2022 · 0 comments · Fixed by #3383
Assignees
@kalinkrustev
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.0

Comments

@kalinkrustev
Copy link
Contributor

Describe the bug

p-button-icon-only class applied incorrectly for

<Button icon="pi pi-check">Label</Button>

Reproducer

https://codesandbox.io/s/primereact-test-forked-14mo08

PrimeReact version

8.6.1

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

See the reproducer URL

Expected behavior

Button with icon and children should not apply the p-button-icon-only class
@kalinkrustev kalinkrustev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 29, 2022
kalinkrustev added a commit to kalinkrustev/primereact that referenced this issue Sep 29, 2022
@kalinkrustev
fix: primefaces#3382
0b6b2b3
@kalinkrustev kalinkrustev mentioned this issue Sep 29, 2022
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 29, 2022
@melloware melloware added this to the 8.6.2 milestone Sep 29, 2022
melloware pushed a commit that referenced this issue Sep 29, 2022
@kalinkrustev
fix: #3382 (#3383)
70815e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalinkrustev kalinkrustev

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.0
Development

Successfully merging a pull request may close this issue.

Fix: #3382 - Button: bad rendering for button with icon and children kalinkrustev/primereact
2 participants
@kalinkrustev @melloware