Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: RowReorder fails in case of pagination on page other than first & last #3817

Closed
himanshu2454 opened this issue Dec 23, 2022 · 1 comment · Fixed by #3818
Closed

DataTable: RowReorder fails in case of pagination on page other than first & last #3817

himanshu2454 opened this issue Dec 23, 2022 · 1 comment · Fixed by #3818
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
9.0.0-beta.1

Comments

@himanshu2454
Copy link

Describe the bug

Hi Team,
I'm working on DataTable component, per my requirement I need to use reordering with pagination, but reordering is failing on page otherthan first & last.

Reproducer

https://codesandbox.io/s/lingering-leftpad-2hwboj

PrimeReact version

6.0.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

chrome

Steps to reproduce the behavior

  1. Go to page 2, reorder element
  2. check console, it show unexplained undefined values

Expected behavior

Should return the ordered array for the particular page
@himanshu2454 himanshu2454 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 23, 2022
@himanshu2454 himanshu2454 changed the title Rowreorder fails in case of pagination on page other first & last in DataTable RowReorder fails in case of pagination on page other than first & last in DataTable Dec 23, 2022
@melloware
Copy link
Member

Looks like this was fixed in PrimeNG 3 years ago: primefaces/primeng@023a2c5

@melloware melloware self-assigned this Dec 23, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 23, 2022
@melloware melloware added this to the 8.7.4 milestone Dec 23, 2022
melloware added a commit to melloware/primereact that referenced this issue Dec 23, 2022
@melloware
Fix primefaces#3817: Row reorder fixes from PrimeNG
ff41965
This was referenced Dec 23, 2022
Merged
Closed
melloware added a commit that referenced this issue Dec 23, 2022
@melloware
Fix #3817: Row reorder fixes from PrimeNG (#3818)
0d313c0
@melloware melloware changed the title RowReorder fails in case of pagination on page other than first & last in DataTable DataTable: RowReorder fails in case of pagination on page other than first & last Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix #3817: Row reorder fixes from PrimeNG melloware/primereact
2 participants
@melloware @himanshu2454