Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrollTop: doesn't work #4505

Closed
samir-ah opened this issue Jun 13, 2023 · 1 comment · Fixed by #4507
Closed

ScrollTop: doesn't work #4505

samir-ah opened this issue Jun 13, 2023 · 1 comment · Fixed by #4507
Assignees
@melloware
Labels
React 18 Issue or pull request is *only* related to React 18 Type: Bug Issue contains a defect related to a specific component.
Milestone
9.6.0

Comments

@samir-ah
Copy link

Describe the bug

The ScrollTop component, as demonstrated in the provided StackBlitz and codesandbox example in the PrimeReact documentation, seems to be not working. Additionally, the issue persists when testing it in my local environment.

Reproducer

https://codesandbox.io/s/5uuss1

PrimeReact version

9.5.0

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

chrome

Steps to reproduce the behavior

when scrolling down there is no scrolltop component in the dom

Expected behavior

scrollcomponent must appear when scrolling down
@samir-ah samir-ah added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 13, 2023
@samir-ah samir-ah changed the title Component: ScrollTop Component: ScrollTop doesn't work Jun 13, 2023
@melloware melloware changed the title Component: ScrollTop doesn't work ScrollTop: doesn't work Jun 13, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 13, 2023
@melloware melloware self-assigned this Jun 13, 2023
@melloware melloware added this to the 9.6.0 milestone Jun 13, 2023
melloware added a commit to melloware/primereact that referenced this issue Jun 13, 2023
@melloware
Fix primefaces#4505: ScrollTop not mounting
9fd72af
@melloware melloware mentioned this issue Jun 13, 2023
Merged
melloware added a commit that referenced this issue Jun 13, 2023
@melloware
Fix #4505: ScrollTop not mounting (#4507)
4f26f87
@melloware
Copy link
Member

@samir-ah just a note this is only not working in React 18 Strict mode. if you disable Strict mode it is working.

@melloware melloware added the React 18 Issue or pull request is *only* related to React 18 label Jun 13, 2023
@mertsincan mertsincan mentioned this issue Nov 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
React 18 Issue or pull request is *only* related to React 18 Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.6.0
Development

Successfully merging a pull request may close this issue.

Fix #4505: ScrollTop not mounting melloware/primereact
2 participants
@melloware @samir-ah