Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Localize pending and file sizes #4872

Closed
melloware opened this issue Sep 3, 2023 · 1 comment · Fixed by #4870
Closed

FileUpload: Localize pending and file sizes #4872

melloware opened this issue Sep 3, 2023 · 1 comment · Fixed by #4870
Assignees
@SoyDiego
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
10.0.0

Comments

@melloware
Copy link
Member

Already done in PrimeNG this is porting over the locale features for FileUpload.

pending: 'Pending',
fileSizeTypes: ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'],
@melloware melloware added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 3, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 3, 2023
@melloware melloware added this to the 10.0.0 milestone Sep 3, 2023
@melloware melloware mentioned this issue Sep 3, 2023
Merged
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 3, 2023
@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 3, 2023

+1

melloware pushed a commit that referenced this issue Sep 3, 2023
@SoyDiego
Fix #4872: Added filesizeTypes Locale (#4870)
0bf4b83 
* Added fileSizeTypes

* refactor formatSize and added localeOption fileupload

* Added fileSizeTypes

* refactor formatSize and added localeOption fileupload

* Added translation fileupload

* added format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoyDiego SoyDiego

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #4872: Added filesizeTypes Locale SoyDiego/primereact
2 participants
@melloware @SoyDiego