Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: Menu with popup prop passed doesnot close on Escape keypress. #5044

Closed
akshayaqburst opened this issue Oct 5, 2023 · 0 comments · Fixed by #5045
Closed

Menu: Menu with popup prop passed doesnot close on Escape keypress. #5044

akshayaqburst opened this issue Oct 5, 2023 · 0 comments · Fixed by #5045
Assignees
@akshayaqburst
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.3

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

Menu: Menu with popup prop passed doesnot close on Escape keypress.

Reproducer

No response

PrimeReact version

10.x.x

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Click on Menu from sidebar.
  2. Go to popup section inside Menu.
  3. Click on Show Left button, a popup arises.
  4. Click on Escape button, popup does not close.

Expected behavior

Popup should close on escape key press.
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 5, 2023
akshayantony55 added a commit to qburst/primereact_qb_10 that referenced this issue Oct 5, 2023
@akshayantony55
fix Primefaces primefaces#5044 Menu with popup prop passed doesnot cl…
a7a423b 
…ose on Escape keypress
@akshayaqburst akshayaqburst mentioned this issue Oct 5, 2023
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 5, 2023
@melloware melloware added this to the 10.0.3 milestone Oct 5, 2023
melloware pushed a commit that referenced this issue Oct 5, 2023
@akshayaqburst @akshayantony55
fix Primefaces #5044 Menu with popup prop passed doesnot close on Esc…
7598e24 
…ape keypress (#5045)

Co-authored-by: akshayantony55 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.3
2 participants
@melloware @akshayaqburst