Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve block/unblockScroll architecture #5077

Closed
6 tasks done
habubey opened this issue Oct 11, 2023 · 1 comment
Closed
6 tasks done

Improve block/unblockScroll architecture #5077

habubey opened this issue Oct 11, 2023 · 1 comment
Assignees
@habubey
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
10.0.3

Comments

@habubey
Copy link
Contributor

habubey commented Oct 11, 2023 •
edited
Loading

Describe the bug

Related to primefaces/primevue#882

When calculating the width of the scroll bar, the calculation should be made only on the document.body element.

Affected components;

  • BlockUI
  • Calendar
  • Dialog
  • Galleria
  • Image
  • Sidebar

Reproducer

No response

PrimeReact version

10.0.2

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@habubey habubey added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 11, 2023
@habubey habubey added this to the 10.0.3 milestone Oct 11, 2023
@habubey habubey self-assigned this Oct 11, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2023
@habubey habubey removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2023
mertsincan added a commit that referenced this issue Oct 11, 2023
@mertsincan
Refactor #5077
15e555c
@melloware
Copy link
Member

I think this issue is related? #5031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@habubey habubey

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
10.0.3
Development

No branches or pull requests
2 participants
@melloware @habubey