Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primereact in the Shadow DOM has problems with the Dropdown component style #5246

Closed
rogiermulders opened this issue Nov 6, 2023 · 1 comment · Fixed by #5566
Closed

Primereact in the Shadow DOM has problems with the Dropdown component style #5246

rogiermulders opened this issue Nov 6, 2023 · 1 comment · Fixed by #5566
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.1

Comments

@rogiermulders
Copy link

rogiermulders commented Nov 6, 2023 •
edited
Loading

Describe the bug

I have Primereact running in a shadowRoot but there are problems.

Tailwind does at the moment a better job than the normal theme css but the Dropdown is not OK

Reproducer

https://stackblitz.com/edit/vitejs-vite-nuemax?file=src%2Fmain.jsx

PrimeReact version

10

React version

18.x

Language

ALL

Build / Runtime

Vite

Browser(s)

all

Steps to reproduce the behavior

You can see in Stackblitz. You still see the original component Expected behavior Not see the select and input component
@rogiermulders rogiermulders added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 6, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Component: Tailwind Tailwind specific issue labels Nov 6, 2023
@melloware
Copy link
Member

Looks similar to #5240

@melloware melloware mentioned this issue Nov 6, 2023
Closed
mondaychen added a commit to mondaychen/primereact that referenced this issue Dec 10, 2023
@mondaychen
feat primefaces#5246: add styleContainer option for useStyle
0276a1b
@mondaychen mondaychen mentioned this issue Dec 10, 2023
Merged
@melloware melloware added this to the 10.2.2 milestone Dec 10, 2023
@gucal gucal modified the milestones: 10.3.0, 10.3.1 Jan 5, 2024
mondaychen added a commit to mondaychen/primereact that referenced this issue Jan 5, 2024
@mondaychen
feat primefaces#5246: add styleContainer option for useStyle
6f25e3b
melloware pushed a commit that referenced this issue Jan 5, 2024
@mondaychen
feat #5246: add styleContainer option for PrimeReactContext (#5566)
3afafe7 
* feat #5246: add styleContainer option for useStyle

* Pass `context.styleContainer` to `DomHandler.createInlineStyle`

* Add docs for StyleContainer
@melloware melloware modified the milestones: 10.3.1, 10.4.0 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.1
Development

Successfully merging a pull request may close this issue.

feat #5246: add styleContainer option for PrimeReactContext mondaychen/primereact
3 participants
@rogiermulders @melloware @gucal