Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind Theming for Button uses a property plain but plain is not part of ButtonProps #5273

Closed
Dalorzo opened this issue Nov 10, 2023 · 1 comment · Fixed by #5274
Closed
Assignees
Labels
Component: Tailwind Tailwind specific issue
Milestone

Comments

@Dalorzo
Copy link
Contributor

Dalorzo commented Nov 10, 2023

Describe the bug

Under Theming for Button, documentation/example uses a property plain but plain is not part of ButtonProps

https://primereact.org/button/

{
                    'bg-transparent border-transparent': props.text && !props.plain,
                    'text-blue-500 hover:bg-blue-300/20': props.text && (props.severity === null || props.severity === 'info') && !props.plain,
                    'text-gray-500 hover:bg-gray-300/20': props.text && props.severity === 'secondary' && !props.plain,
                    'text-green-500 hover:bg-green-300/20': props.text && props.severity === 'success' && !props.plain,
                    'text-orange-500 hover:bg-orange-300/20': props.text && props.severity === 'warning' && !props.plain,
                    'text-purple-500 hover:bg-purple-300/20': props.text && props.severity === 'help' && !props.plain,
                    'text-red-500 hover:bg-red-300/20': props.text && props.severity === 'danger' && !props.plain
                },
                ```
               
                
                

### Reproducer

_No response_

### PrimeReact version

10.0.9

### React version

18.x

### Language

TypeScript

### Build / Runtime

Create React App (CRA)

### Browser(s)

_No response_

### Steps to reproduce the behavior

_No response_

### Expected behavior

_No response_
@Dalorzo Dalorzo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 10, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 10, 2023
@melloware melloware self-assigned this Nov 10, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 10, 2023
@melloware
Copy link
Member

I will fix looks like this was missed when porting from PrimeVue.

melloware added a commit to melloware/primereact that referenced this issue Nov 10, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Type: Bug Issue contains a defect related to a specific component. labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants