InputText inherits size from HTMLInputElement and size is number

[Dalorzo]

Describe the bug

The HTMLInputElement interface provides special properties and methods for manipulating the options, layout, and presentation of <input> elements.
Supported by:
Chrome, Chrome Android, Edge, Firefox, Opera 8, Safari, Safari iOS
By Mozilla Contributors , CC BY-SA 2.5 

https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement
***size: unsigned long:***

However, it is used by primereact as a string :

{
 'text-lg px-4 py-4': props.size == 'large',
 'text-xs px-2 py-2': props.size == 'small',
 'p-3 text-base': props.size == null
}

Reproducer

No response

PrimeReact version

10.0.9

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

1. Go to https://primereact.org/inputtext/
2. Under tab theming

Expected behavior

From my POV this seems a violation of the Solid principle of Liskov Substitution Principle or Composition over inheritance.

[melloware]

I don't understand your issue?

[Dalorzo]

@melloware thanks for looking into this. Allow me to elaborate, the size property is of type number, it is not a string.

InputHTML the property size is number. However, it is being used as it if it were a string e.x. props.size == 'large'

Please do not hesitate to reach out if you need additional details or if you would like to discuss the issue further

[melloware]

Got it. Easy fix.