Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailwind: Under DataTable theming props.frozenRow but are not DataTableProps #5288

Closed
Dalorzo opened this issue Nov 11, 2023 · 4 comments · Fixed by #5289 or #5293
Closed

Tailwind: Under DataTable theming props.frozenRow but are not DataTableProps #5288

Dalorzo opened this issue Nov 11, 2023 · 4 comments · Fixed by #5289 or #5293
Assignees
@Dalorzo
Labels
Component: Tailwind Tailwind specific issue Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.1.0

Comments

@Dalorzo
Copy link
Contributor

Dalorzo commented Nov 11, 2023 •
edited
Loading

Describe the bug

Under DataTable theming

  • props.frozenRow

Are not part of DataTableProps therefore cannot be used.

Reproducer

No response

PrimeReact version

10.0.9

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Should part of ColumnProps

  • props.showGridlines and
  • props.frozenRow
@Dalorzo Dalorzo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 11, 2023
@melloware
Copy link
Member

Wait but they are datatable props not column props?

@Dalorzo
Copy link
Contributor Author

Dalorzo commented Nov 11, 2023

image

@melloware
Copy link
Member

Sorry please start tickets like this with Tailwind: so I know it's tailwind related!

Do you want to submit a PR?

@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 11, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 11, 2023
@melloware melloware changed the title Under DataTable theming props.showGridlines and props.frozenRow but are not ColumnProps Tailwind: Under DataTable theming props.showGridlines and props.frozenRow but are not ColumnProps Nov 11, 2023
@Dalorzo Dalorzo changed the title Tailwind: Under DataTable theming props.showGridlines and props.frozenRow but are not ColumnProps Tailwind: Under DataTable theming props.frozenRow but are not DataTableProps Nov 11, 2023
Dalorzo added a commit to Dalorzo/primereact that referenced this issue Nov 11, 2023
@Dalorzo
Adding frozenRow to DataTableProps primefaces#5288
7635846
@Dalorzo Dalorzo mentioned this issue Nov 11, 2023
Merged
Dalorzo added a commit to Dalorzo/primereact that referenced this issue Nov 11, 2023
@Dalorzo
Adding frozenRow to DataTableProps primefaces#5288
34ae919
@melloware melloware linked a pull request Nov 12, 2023 that will close this issue
Adding frozenRow to DataTableProps #5288 #5289
Merged
melloware pushed a commit that referenced this issue Nov 12, 2023
@Dalorzo
Adding frozenRow to DataTableProps #5288 (#5289)
fb94e4e
melloware added a commit to melloware/primereact that referenced this issue Nov 12, 2023
@melloware
Revert "Adding frozenRow to DataTableProps primefaces#5288 (primeface…
aa495f3 
…s#5289)"

This reverts commit fb94e4e.
melloware added a commit that referenced this issue Nov 12, 2023
@melloware
Revert "Adding frozenRow to DataTableProps #5288 (#5289)" (#5292)
3ca3738 
This reverts commit fb94e4e.
@melloware melloware reopened this Nov 12, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 12, 2023
@melloware
Copy link
Member

melloware commented Nov 12, 2023 •
edited
Loading

Reverted this. frozenRow is not a public variable so thus its not exposed in the TypeScript.

Frozen Table:

primereact/components/lib/datatable/DataTable.js

Line 1617 in 45fdd70

frozenRow

Non Frozen Table:

primereact/components/lib/datatable/DataTable.js

Line 1685 in 45fdd70

frozenRow={false}

@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 12, 2023
@melloware melloware removed this from the 10.0.10 milestone Nov 12, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 12, 2023
@melloware
Fix primefaces#5288: Datatable add readonly frozenRow property
010360a
@melloware melloware mentioned this issue Nov 12, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue Nov 12, 2023
@melloware
Fix primefaces#5288: Datatable add readonly frozenRow property
575420e
melloware added a commit to melloware/primereact that referenced this issue Nov 12, 2023
@melloware
Fix primefaces#5288: Datatable add readonly frozenRow property
4d2fde1
@melloware melloware added the Typescript Issue or pull request is *only* related to TypeScript definition label Nov 12, 2023
melloware added a commit that referenced this issue Nov 12, 2023
@melloware
Fix #5288: Datatable add readonly frozenRow property (#5293)
692ddb7
melloware added a commit that referenced this issue Nov 12, 2023
@melloware
Fix #5288: Datatable add readonly frozenRow property
fec6de0
@melloware melloware added this to the 10.0.10 milestone Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dalorzo Dalorzo

Labels
Component: Tailwind Tailwind specific issue Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.1.0
2 participants
@melloware @Dalorzo