Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed Dial: Speed Dial Menu does not close on escape key press #5367

Closed
navedqb opened this issue Nov 22, 2023 · 0 comments · Fixed by #5368
Closed

Speed Dial: Speed Dial Menu does not close on escape key press #5367

navedqb opened this issue Nov 22, 2023 · 0 comments · Fixed by #5368
Assignees
@navedqb
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
10.2.0

Comments

@navedqb
Copy link
Contributor

navedqb commented Nov 22, 2023

Describe the bug

Speed Dial menu does not close on escape key press.

Reproducer

https://primereact.org/speeddial/

PrimeReact version

10.1.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Go to https://primereact.org/speeddial
  2. Open Speed Dial menu
  3. Press escape

Expected behavior

Speed Dial menu should close on escape key press.
@navedqb navedqb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 22, 2023
@navedqb navedqb mentioned this issue Nov 22, 2023
Merged
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2023
@melloware melloware added this to the 10.2.0 milestone Nov 22, 2023
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5367: SpeedDial close on escape
d67b263
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes2 (#5710)
24e22e0 
* Fix #5349: PanelMenu fix from PrimeVue

* Fix #5360: Cascade select popup not closing on escape

* fix: #5363, Mention: Page Breaks when navigating to Mention component

* fix: #5365 SplitButton popup not closing on escape button click

* Fix #5367: SpeedDial close on escape

* Fix #2666: Fix overlay components in cell editor

* Fix #5363: Mention better fix

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues

* Fix #5385: Password inputClassname missing

* Fix #5390: Calendar only render navigator in first month of multiple months

* Fix #5202: Calendar rendering performance increase

* Fix #5535: Calendar update input on locale change

* Fix #5533/#4147: Calendar respect viewDate

* Fix Calendar Input Docs

* fix:Calendar:currentView changed should invoke alignOverlay

* Fix #5379: Accordion tab header passthrough errors
Fix #5546: AccordionTab Tailwind issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navedqb navedqb

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
10.2.0
Development

Successfully merging a pull request may close this issue.

fix: fix speed dial menu not closing on escape qburst/primereact-1
2 participants
@melloware @navedqb