Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeTable: selected rows are not highlighted #5370

Closed
BAISTM opened this issue Nov 22, 2023 · 5 comments · Fixed by #5372 or #5703
Closed

TreeTable: selected rows are not highlighted #5370

BAISTM opened this issue Nov 22, 2023 · 5 comments · Fixed by #5372 or #5703
Assignees
@melloware @nitrogenous @gucal
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
10.3.1

Comments

@BAISTM
Copy link

BAISTM commented Nov 22, 2023

Describe the bug

For components homogeneities, the rows selected using checkbox selection should be highlighted like DataTable component.

Reproducer

https://codesandbox.io/p/sandbox/primereact-demo-2fyn7s?file=%2Fsrc%2Findex.js

PrimeReact version

10.0.9

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@BAISTM BAISTM added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 22, 2023
@melloware
Copy link
Member

melloware commented Nov 22, 2023 •
edited
Loading

It looks like it TreeTable that is intentional as its the same way in PrimeVue: https://primevue.org/treetable/#checkbox_row_selection

It looks like Checkbox mode intentionally does not highlight the rows but the other modes like "single" selection do.

@melloware melloware added Status: Discussion Issue or pull request needs to be discussed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2023
@BAISTM
Copy link
Author

BAISTM commented Nov 22, 2023

@melloware Thanks you for your quick response.

In the DataTable component, the checkbox mode highlights the selected rows, see https://codesandbox.io/p/sandbox/primereact-demo-dsrfsm?file=%2Fsrc%2Findex.js

It's not intuitive for users because the user will not know why when it's a simple table the rows are highlighted and when it's a tree table the rows are not highlighted.

@melloware
Copy link
Member

Yep I marked it for "discussion" for PrimeTek since it affects other PrimeLibs.

@melloware
Copy link
Member

Interesting the PrimeNG TreeTable does highlight: https://primeng.org/treetable#checkbox

melloware added a commit to melloware/primereact that referenced this issue Nov 22, 2023
@melloware
Fix primefaces#5370: TreeTable highlight selection in Checkbox mode
ee5f57c
@melloware melloware mentioned this issue Nov 22, 2023
Merged
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Discussion Issue or pull request needs to be discussed by Core Team labels Nov 22, 2023
@melloware melloware added this to the 10.2.0 milestone Nov 22, 2023
@melloware melloware self-assigned this Nov 22, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 22, 2023
@melloware
Fix primefaces#5370: TreeTable highlight selection in Checkbox mode
a61190a
melloware added a commit that referenced this issue Nov 24, 2023
@melloware
Fix #5370: TreeTable highlight selection in Checkbox mode (#5372)
c3ee3c1
@FAMSTM
Copy link

FAMSTM commented Jan 8, 2024

v10.3.0 broke this fix: the selected rows using checkbox are not highlighted again

@melloware melloware modified the milestones: 10.2.0, 10.3.1 Jan 8, 2024
@melloware melloware reopened this Jan 8, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2024
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 8, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 8, 2024
@melloware
Fix primefaces#5640
b514752 
Fix primefaces#5556
Fix primefaces#5487
Fix primefaces#5457
Fix primefaces#5370
Fix primefaces#4051
@melloware melloware mentioned this issue Jan 8, 2024
Merged
@melloware melloware modified the milestones: 10.3.1, 10.4.0 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

@nitrogenous nitrogenous

@gucal gucal

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
10.3.1
5 participants
@melloware @nitrogenous @gucal @FAMSTM @BAISTM