Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password: (accessiblility) cannot access toggle button using keyboard #6046

Closed
arnodemer opened this issue Feb 27, 2024 · 6 comments · Fixed by #6052
Closed

Password: (accessiblility) cannot access toggle button using keyboard #6046

arnodemer opened this issue Feb 27, 2024 · 6 comments · Fixed by #6052
Assignees
@akshayaqburst
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.5.2

Comments

@arnodemer
Copy link
Contributor

Describe the bug

focus cannot be moved to Password's toggle button, then cannot toggle using keyboard

Reproducer

No response

PrimeReact version

10.5.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. go to Password toggle show case : https://primereact.org/password/#togglemask
  2. use tab to set focus on password field
  3. hit tab several times, focus is never set on toggle password button

Expected behavior

Toggle button should be able to be activated using keyboard
Focus should also stay on toggle button when password state is toggled.
@arnodemer arnodemer added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 27, 2024
@arnodemer arnodemer changed the title Password: (accessiblility) cannot acces toggle button using keyboard Password: (accessiblility) cannot access toggle button using keyboard Feb 27, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 27, 2024
@melloware
Copy link
Member

Agreed it looks like PrimeVue has not implemented this yet either.

@akshayaqburst
Copy link
Contributor

@melloware Can I work on this?

@arnodemer
Copy link
Contributor Author

Hi ! it would be nice if we could also set a tooltip for this toggle button (password component already have one, but it's for input ).
Thanks a lot !

@melloware
Copy link
Member

@akshayaqburst sure!

akshayaqburst pushed a commit to qburst/primereact_qb_26 that referenced this issue Feb 28, 2024
@akshayantony55
fix: primefaces primefaces#6046, Password: (accessiblility) cannot ac…
fb6e5af 
…cess toggle button using keyboard
@akshayaqburst akshayaqburst mentioned this issue Feb 28, 2024
Merged
akshayaqburst pushed a commit to qburst/primereact_qb_26 that referenced this issue Feb 28, 2024
@akshayantony55
fix: primefaces primefaces#6046, Password: (accessiblility) cannot ac…
b8c29d9 
…cess toggle button using keyboard
@akshayaqburst
Copy link
Contributor

@melloware Created PR for review - #6052. Thanks,

@melloware
Copy link
Member

Some code review comments. Looking good so far!

@melloware melloware added this to the 10.5.2 milestone Feb 28, 2024
akshayaqburst pushed a commit to qburst/primereact_qb_26 that referenced this issue Feb 28, 2024
@akshayantony55
fix: primefaces primefaces#6046, Password: (accessiblility) cannot ac…
0dc360e 
…cess toggle button using keyboard
akshayaqburst pushed a commit to qburst/primereact_qb_26 that referenced this issue Feb 28, 2024
@akshayantony55
fix: primefaces primefaces#6046, Password: (accessiblility) cannot ac…
d5cdfd1 
…cess toggle button using keyboard
akshayaqburst pushed a commit to qburst/primereact_qb_26 that referenced this issue Feb 28, 2024
@akshayantony55
fix: primefaces primefaces#6046, Password: (accessiblility) cannot ac…
228aaa7 
…cess toggle button using keyboard
nitrogenous added a commit that referenced this issue Mar 18, 2024
@nitrogenous
Merge pull request #6052 from qburst/master
ea7448d 
Fix #6046, Password: (accessiblility) cannot access toggle button using keyboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.5.2
3 participants
@melloware @akshayaqburst @arnodemer