Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galleria: Galleria image in fullscreen mode not closing on escape button click #6644

Closed
akshayaqburst opened this issue May 21, 2024 · 0 comments · Fixed by #6645, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Closed

Galleria: Galleria image in fullscreen mode not closing on escape button click #6644

akshayaqburst opened this issue May 21, 2024 · 0 comments · Fixed by #6645, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Assignees
@akshayaqburst
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.6

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

Galleria: Galleria image in fullscreen mode not closing on escape button click

Reproducer

No response

PrimeReact version

10.6.5

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primereact.org/galleria/#fullscreen.
  2. Click on show button and popup appears.
  3. Click escape button.
  4. Popup does not close.

Expected behavior

The image popup should close on escape button click
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 21, 2024
akshayaqburst pushed a commit to qburst/primereact_qb_30 that referenced this issue May 21, 2024
fix: primefaces#6644, Galleria: Galleria image in fullscreen mode not…
7c6ea86 
… closing on escape button click
@akshayaqburst akshayaqburst mentioned this issue May 21, 2024
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 21, 2024
@melloware melloware added this to the 10.7.0 milestone May 21, 2024
nitrogenous added a commit that referenced this issue May 24, 2024
@nitrogenous
Merge pull request #6645 from qburst/master
3f0d1a6 
fix: #6644, Galleria: Galleria image in fullscreen mode not closing on escape button click
@leoo1992 leoo1992 mentioned this issue Jun 14, 2024
Merged
@raymondhtet raymondhtet mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.6
2 participants
@melloware @akshayaqburst